Re: [rtc-linux] Re: [PATCH 1/7] Blackfin RTC driver: the frequencyfunction is in units of Hz, not units of seconds, so lock our driver downto 1 Hz

[Alessandro Zummo]

On Tue, 4 Dec 2007 11:56:54 -0500
"Mike Frysinger" <vapier.adi@xxxxxxxxx> wrote:

> On Dec 4, 2007 11:49 AM, Alessandro Zummo <alessandro.zummo@xxxxxxxxxxxx> wrote:
> > On Tue, 4 Dec 2007 11:47:56 -0500
> > "Mike Frysinger" <vapier.adi@xxxxxxxxx> wrote:
> > > the return of ENOTTY is to say "changing of freq isnt supported", not
> > > that the value is invalid.  but i can get the same behavior by
> > > deleting the function as the rtc-dev layer will take care of returning
> > > ENOTTY.
> > >
> > > so the behavior is for the RTC_IRQP_SET ioctl:
> > >  - return ENOTTY if you cannot change freq
> > >    - the rtc-dev layer will do this for you if you do not set irq_set_freq
> > >  - return EINVAL if the requested freq is not within the capabilities
> > > of the hardware
> > >
> > > sound about right ?
> >
> >  yes, it is. I agree about deleting it.
> 
> so, merge this patch and i'll follow up with another to delete the
> func and update the documentation ?

 ok. You have my 

 Signed-off-by: Alessandro Zummo <a.zummo@xxxxxxxxxxxx>

 on the whole patch set.

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/