Re: 2.6.24-rc3-git6: Reported regressions from 2.6.23

From: Jeff Garzik
Date: Tue Dec 04 2007 - 14:12:55 EST


Bartlomiej Zolnierkiewicz wrote:
On Saturday 01 December 2007, Rafael J. Wysocki wrote:

Subject : 2.6.24-rc1: pata_amd fails to detect 80-pin wire
Submitter : "Thomas Lindroth" <thomas.lindroth@xxxxxxxxx>
References : http://lkml.org/lkml/2007/11/7/152
http://bugzilla.kernel.org/show_bug.cgi?id=9322
Handled-By : Tejun Heo <htejun@xxxxxxxxx>
Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
Patch : http://lkml.org/lkml/2007/11/11/115

Tejun's rework of cable detection code which fixes the problem has
been just applied into "upstream" (not "upstream-fixes") so it is
destined for 2.6.25 (I wasn't on cc: BTW) and since I got no feedback
on my patch (below) which also happens to fix the regression, was
acked by Alan, tested by Thomas and has been in -mm for 3 weeks now
I assume that everybody is happy with it (Jeff/Tejun: you were also
on cc: when the patch was merged into -mm)...

Linus, please apply.

[PATCH] pata_amd/pata_via: de-couple programming of PIO/MWDMA and UDMA timings

* Don't program UDMA timings when programming PIO or MWDMA modes.

This has also a nice side-effect of fixing regression added by commit
681c80b5d96076f447e8101ac4325c82d8dce508 ("libata: correct handling of
SRST reset sequences") (->set_piomode method for PIO0 is called before
->cable_detect method which checks UDMA timings to get the cable type).

* Bump driver version.

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
Tested-by: "Thomas Lindroth" <thomas.lindroth@xxxxxxxxx>
Acked-by: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>
Cc: Jeff Garzik <jeff@xxxxxxxxxx>
Cc: Tejun Heo <htejun@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>

applied #upstream-fixes


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/