Re: [RFC PATCH] x86: Unify include/asm-x86/linkage_[32|64].h

[Harvey Harrison]

On Tue, 2007-12-04 at 23:27 +0100, Ingo Molnar wrote:
> * Harvey Harrison <harvey.harrison@xxxxxxxxx> wrote:
> > OK, but if this patch is acceptable, then there is no more places in 
> > the tree that define the FASTCALL macro, other than the empty default 
> > in include/linux/linkage.h.  So I think a second step would be to 
> > start to get rid of FASTCALL callers elsewhere in the tree...thoughts?
> 
> the removal of FASTCALL is fine: the default (and only) compiler model 
> for x86 (32-bit) is regparm(3), so the regparm(3) macro is equivalent to 
> the empty one in linux/linkage.h.
> 
> btw., removal of FASTCALL from the tree is worthwile after this: it 
> should probably be done via the -mm tree, because it's more of a generic 
> kernel matter than an arch/x86 matter.
> 
> 	Ingo

Agreed, just noting that there was nobody defining it anymore, it's
widespread enough that I'll submit them separately to appropriate
maintainers and they can dribble in over time.

Cheers,

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/