Re: Patch submission question [not in the FAQ]

[WANG Cong]

On Wed, Dec 05, 2007 at 03:36:54AM -0800, Gabriele Gorla wrote:
>Hello,
>I have submitted a patch for the 3x-xxxx driver on
>alpha several months ago to both the driver maintainer
>and the linux-scsi mailing list.
>I have read all the FAQ and I tried to stick to the
>instructions to the letter.
>However the patch has been completely ignored. No
>reply, no comment, no flames, absolutely nothing...
>
>the original email submission is at the end of the
>email.
>
>could anyone please explain what I am doing wrong?
>
>thanks,
>GG
>
>
>[PATCH 2.6.22] 3w-xxxx: Fix bad unaligned accesses on
>alpha SMP
>
>disable packing of the TAG_TW_Device_Extension
>structure to prevent kernel unaligned accesses when
>accessing ioctl_wqueue.
>Fixes smartmontools kernel panic on alpha SMP
>
>Signed-off-by: Gabriele Gorla <gorlik@xxxxxxxxx>
>---
>
>
>--- linux-2.6.22/drivers/scsi/3w-xxxx.h.orig
>2007-09-01 17:49:22.000000000 -0700
>+++ linux-2.6.22/drivers/scsi/3w-xxxx.h 2007-09-01
>17:49:45.000000000 -0700

It seems that your email client wraps lines.
Please don't do this when you submit patches.


>@@ -392,6 +392,8 @@ typedef struct TAG_TW_Passthru
>        unsigned char padding[12];
> } TW_Passthru;

And also your email clients eats tabs.

Read Documentation/SubmittingPatches, please.
And read Documentation/email-clients.txt to learn more.

Regards.


 Cong

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/