Re: PS3: trouble with SPARSEMEM_VMEMMAP and kexec

[Andrew Morton]

On Wed, 5 Dec 2007 10:52:48 +0100 (CET)
Geert Uytterhoeven <Geert.Uytterhoeven@xxxxxxxxxxx> wrote:

> --------------------------------------------------------------------------------
> Subject: sparsemem: sparse_add_one_section() may fail to allocate memory
> 
> sparsemem: sparse_add_one_section() may fail to allocate memory, and must check
> whether the allocation succeeded before proceeding to touch the allocated
> memory.
> 
> From: Geert Uytterhoeven <Geert.Uytterhoeven@xxxxxxxxxxx>
> 
> Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@xxxxxxxxxxx>
> ---
> FIXME There are still some possible memory leaks in sparse_add_one_section():
>   - usemap is never deallocated
>   - __kfree_section_memmap() is a not yet implemented dummy

I already had

ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc4/2.6.24-rc4-mm1/broken-out/mm-sparsec-improve-the-error-handling-for-sparse_add_one_section.patch
and
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc4/2.6.24-rc4-mm1/broken-out/mm-sparsec-check-the-return-value-of-sparse_index_alloc.patch

queued.  Do they fix the problem, and should they be merged in 2.6.24?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/