[PATCH 2/3] DRM: don't cast a pointer to pointer of list_head

From: Li Zefan
Date: Thu Dec 06 2007 - 04:38:22 EST



The casting is safe only when the list_head member is the
first member of the structure.

Signed-off-by: Li Zefan <lizf@xxxxxxxxxxxxxx>

---
drivers/char/drm/i915_irq.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/char/drm/i915_irq.c b/drivers/char/drm/i915_irq.c
index a443f4a..e9e8522 100644
--- a/drivers/char/drm/i915_irq.c
+++ b/drivers/char/drm/i915_irq.c
@@ -555,7 +555,7 @@ int i915_vblank_swap(struct drm_device *dev, void *data,

spin_lock_irqsave(&dev_priv->swaps_lock, irqflags);

- list_add_tail((struct list_head *)vbl_swap, &dev_priv->vbl_swaps.head);
+ list_add_tail(&vbl_swap->head, &dev_priv->vbl_swaps.head);
dev_priv->swaps_pending++;

spin_unlock_irqrestore(&dev_priv->swaps_lock, irqflags);
--
1.5.3.rc7

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/