Re: [Patch] net/xfrm/xfrm_policy.c: Some small improvements

From: David Miller
Date: Thu Dec 06 2007 - 06:14:47 EST


From: WANG Cong <xiyou.wangcong@xxxxxxxxx>
Date: Thu, 6 Dec 2007 19:01:23 +0800

>
> This patch contains the following changes.
>
> - Use 'bool' instead of 'int' for booleans.
> - Use 'size_t' instead of 'int' for 'sizeof' return value.
> - Some style fixes.
>
> Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> Cc: David Miller <davem@xxxxxxxxxxxxx>
> Signed-off-by: WANG Cong <xiyou.wangcong@xxxxxxxxx>

Normally I would let a patch like this sit in my mailbox
for a week and then delete it.

But this time I'll just let you know up front that I
don't see much value in this patch. It is not a clear
improvement to replace int's with bool's in my mind and
the other changes are just whitespace changes.

And thus I can delete the patch from my mailbox
immediately :-)

Sorry.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/