Re: [PATCH] ipwireless_cs driver for 4G PC Card

From: Marcel Holtmann
Date: Thu Dec 06 2007 - 19:30:22 EST


Hi David,

might it not make more sense to put all of that into a new
subdirectory, say, /drivers/char/pcmcia/ipwireless_cs? that way, it's
more modular and it will keep that higher-level directory from
potentially getting cluttered with even more drivers. and it would
let you drop the pointless "ipwireless_cs_" prefix from all of those
files as well.

ok, will put it into ipwireless, and the _cs suffix will go away as suggested
elsewhere. The filenames will then get very generic names, do you have
suggestion for better names? There are many drivers in own directory and
files inside have the same prefix. Maybe we can use names like ipw- hw.c, etc.

don't use "ipw" as prefix. It is too close to the Intel wireless drivers and will only create confusion. The generic filenames in a subdirectory don't matter. The module name is what counts.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/