Re: [PATCH] move the related code from exit_notify() to exit_signals()

[Davide Libenzi]

On Thu, 6 Dec 2007, Oleg Nesterov wrote:

> The previous bugfix was not optimal, we shouldn't care about group stop when
> we are the only thread or the group stop is in progress. In that case nothing
> special is needed, just set PF_EXITING and return.
> 
> Also, take the related "TIF_SIGPENDING re-targeting" code from exit_notify().
> 
> So, from the performance POV the only difference is that we don't trust
> !signal_pending() until we take ->siglock. But this in fact fixes another
> ___pure___ theoretical minor race. __group_complete_signal() finds the task
> without PF_EXITING and chooses it as the target for signal_wake_up(). But
> nothing prevents this task from exiting in between without noticing the
> pending signal and thus unpredictably delaying the actual delivery.

For a second there, you got me confused, since it wasn't clear to me this 
patch was going over the previous one. When posting patches that are not 
in any tree, it may be wise to include the set they nest onto ;)


> +	if (!signal_pending(tsk))
> +		goto out;
> +
> +	/* It could be that __group_complete_signal() choose us to
> +	 * notify about group-wide signal. Another thread should be
> +	 * woken now to take the signal since we will not.
> +	 */
> +	for (t = tsk; (t = next_thread(t)) != tsk; )
> +		if (!signal_pending(t) && !(t->flags & PF_EXITING))
> +			recalc_sigpending_and_wake(t);
> +
> +	if (unlikely(tsk->signal->group_stop_count) &&
> +			!--tsk->signal->group_stop_count) {
> +		tsk->signal->flags = SIGNAL_STOP_STOPPED;
> +		group_stop = 1;
> +	}
> +out:

Looks fine to me, even though the one above could simply be an:

if (signal_pending(tsk)) {
	...
}

(since the "out" label is used by that "if" only).



- Davide


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/