Re: [PATCH] scheduler: fix x86 regression in native_sched_clock

From: Ingo Molnar
Date: Fri Dec 07 2007 - 06:18:21 EST



* Nick Piggin <nickpiggin@xxxxxxxxxxxx> wrote:

> > ah, printk_clock() still uses sched_clock(), not jiffies. So it's
> > not the jiffies counter that goes back and forth, it's sched_clock()
> > - so this is a printk timestamps anomaly, not related to jiffies. I
> > thought we have fixed this bug in the printk code already:
> > sched_clock() is a 'raw' interface that should not be used directly
> > - the proper interface is cpu_clock(cpu).
>
> It's a single CPU box, so sched_clock() jumping would still be
> problematic, no?

sched_clock() is an internal API - the non-jumping API to be used by
printk is cpu_clock().

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/