H. Peter Anvin wrote:Jeremy Fitzhardinge wrote:Harvey Harrison wrote:Yes, that's the whole point (unification.)Some kprobe structure members had a superfluous e in theireflags and esp are the actual machine register names (at least in
name.
eflags -> flags
esp -> sp
32-bit), and therefore more distinctive than just "flags".
If this is in preparation for a unification then OK, but I disagree if
not (and technically 64-bit should be using rsp/rflags).
OK, great. I was just confused because the patch changelog didn't give
a proper rationale for the change (the 'e' isn't superfluous, and
removing it isn't a goal in itself).