Re: [PATCH] logo: move declarations of logos to linux_logo.h

[Sam Ravnborg]

On Thu, Dec 13, 2007 at 08:50:46PM +0100, Marcin Ålusarz wrote:
> On Thu, Dec 13, 2007 at 02:31:11AM -0800, Andrew Morton wrote:
> > On Sun, 9 Dec 2007 22:40:31 +0100 Marcin Ålusarz <marcin.slusarz@xxxxxxxxx> wrote:
> >
> > > logo: move declarations of logos to linux_logo.h
> > >
> > > there was a mismatch between externs in logo.c and code generated by pnmtologo
> > > (on old tree, you need to rm drivers/video/logo/logo_*.c before compilation)
> >
> > This patch (after I fixed it) keeps on causing trouble: mismatches between
> > the header file declarations and the actual definitions of the lookup
> > tables.  This happens as I apply and unapply the patch.
> >
> > It _shouldn't_ happen, but there would appear to be some missing makefile
> > rules.  I guess the C files aren't being regenerated when
> > scripts/pnmtologo.c has been altered, so the C files aren't matching the
> > header which this patch alters.
> Ok, I'll try to fix that.

The kbuild rules around the logo stuff are non-trivial.
Drop me a line (+patch) if you need help.
You may in that case also cc: linux-kbuild@xxxxxxxxxxxxxxxx
There are some quite skilled kbuild people hanging out there too.

I may not respond promptly - busy these days (+ christmas)

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/