Re: Top kernel oopses/warnings this week

[Arjan van de Ven]

Tony Luck wrote:
> > +       static char target[80];
>  ...
> > +               sprintf(target, "%02x%02x%02x%02x-%02x%02x-%02x%02x-%02x%02x-"
> > +                       "%02x%02x%02x%02x%02x%02x",
>
> [80] is overkill ... [37] bytes should be enough (unless I went
> cross-eyed counting the "%02x" :-)

%02x doesn't guarantee that it's at most 2, but at LEAST 2...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/