Re: [RFC, PATCH] sdio: move temporary buffer

[Pierre Ossman]

On Wed, 19 Dec 2007 11:55:25 +0100
Marc Pignat <marc.pignat@xxxxxxx> wrote:

> Move the temporary buffer used by some sdio functions from sdio_func struct to
> the mmc_host struct and make it dma-safe.
> 
> Signed-off-by: Marc Pignat <marc.pignat@xxxxxxx>
> ---
> 
> There is no need to have this temporary buffer in every sdio_func, since all
> access to it are serialized by sdio_[claim/release]_host.
> 

I had some crazy idea about per function locking, but until that time this will do just fine.

> I also think it should be ____cacheline_aligned to make sure we have no data
> loss when doing dma syncing operations.

This is still voodoo to me, so I'll have to take your word for it. :)

> 
> Comments welcome!
> 

Looks good to me.

Rgds
-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/