Re: [PATCH v4 7/8] debugfs: allow access to signed values

[Arnd Bergmann]

On Thursday 20 December 2007, Stefano Brivio wrote:
> debugfs: allow access to signed values
> 
> Add debugfs_create_s{8,16,32,64}. For these to work properly, we need to remove
> a cast in libfs, change the simple_attr_open prototype and thus fix the users as
> well.
> 
> Cc: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
> Cc: Mattias Nissler <mattias.nissler@xxxxxx>
> To: Greg Kroah-Hartman <gregkh@xxxxxxx>
> To: Arnd Bergmann <arndb@xxxxxxxxxx>
> To: Akinobu Mita <akinobu.mita@xxxxxxxxx>
> Signed-off-by: Stefano Brivio <stefano.brivio@xxxxxxxxx>

Have you checked that spufs still builds? I would guess that you need
to do the same interface changes there.

Also, Christoph has recently posted a suggestion for how to improve
the interface to allow the 'get' operation to return an error:
http://patchwork.ozlabs.org/cbe-oss-dev/patch?id=14962

I'd suggest consolidating the two changes in order to avoid merge
conflicts.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/