Re: Update ip command line processing

[David Miller]

From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Tue, 18 Dec 2007 17:57:32 +0900

> @@ -1414,9 +1414,16 @@ late_initcall(ip_auto_config);
>   */
>  static int __init ic_proto_name(char *name)
>  {
> +	if (!name) {
> +		return 1;
> +	}

I do not see any circumstance under which this pointer can
be NULL.  Judging by your other changes, I think you mean
to use "!*name" here.

Maybe:

	if (*name == '\0')

would make it clearer what you're checking for, an
empty string.

Otherwise I'm fine with your change.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/