Re: Trailing periods in kernel messages
From: Andrew Morton
Date: Thu Dec 20 2007 - 21:17:51 EST
On Fri, 21 Dec 2007 02:43:33 +0100 Frans Pop <elendil@xxxxxxxxx> wrote:
> On Thursday 20 December 2007, Alan Cox wrote:
> > The kernel printk messages are sentences.
>
> I'm afraid that I completely and utterly disagree. Kernel messages are _not_
> sentences. The vast majority is not well-formed and does not contain any of
> the elements that are required for a proper sentence.
>
> The most kernel messages can be compared to is a rather diverse and sloppy
> enumeration. And enumerations follow completely different rules than
> sentences. It can better be characterized as a "semi-random sequence of
> context-sensitive technical messages".
>
> IMHO the existing rule that "Kernel messages do not have to be terminated
> with a period." is completely justified, though it does need some minor
> clarification on the cases in which proper punctuation _should_ be
> followed.
No-period is a kernel idiom, produces perfectly readable output, I have
never ever heard of anyone expressing the least concern over a lack of dots
at the end of their printks and 91% of kernel code agrees.
otoh the place where no-dots comes horridly unstuck is if a single printk
contains two sentences:
printk("My computer caught on fire. I hope yours does too\n");
that's really daft. It's very rare though.
Of course one could always patch syslogd to add the dots, or change printk
and add an i_am_anal=1 kernel boot option.
Andy, please have an accident with that checkpatch change and let's hope
like hell that nobody starts trying to "fix" any of this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/