Re: [PATCH] constify tables in kernel/sysctl_check.c

[Jan Beulich]

>>> Eric W. Biederman <ebiederm@xxxxxxxxxxxx> 21.12.07 00:05 >>>
>"Jan Beulich" <jbeulich@xxxxxxxxxx> writes:
>
>> Remains the question whether it is intended that many, perhaps even
>> large, tables are compiled in without ever having a chance to get used,
>> i.e. whether there shouldn't #ifdef CONFIG_xxx get added.
>
>
>The constification looks good.  The file should be compiled only when
>we have sysctl support.  We use those tables when we call 
>register_sysctl_table.  Which we do a lot.

I understand this. Nevertheless, the tables take 23k on 64-bits, and many
of them are unused when certain subsystems aren't being built (and some
are even architecture specific). The arlan tables are a particularly good
example, but the netfilter ones are pretty big and probably not always
used, too.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/