Re: [PATCH 1/2] DMA buffer alignment annotations

[Roland Dreier]

 > > +#define __dma_aligned	  	__attribute__((aligned(ARCH_MIN_DMA_ALIGNMENT)))
 > > +#define __dma_buffer		__dma_buffer_line(__LINE__)
 > > +#define __dma_buffer_line(line)	__dma_aligned;\
 > > +				char __dma_pad_##line[0] __dma_aligned

 > You introduce __dma_buffer_line() if ARCH_MIN_DMA_ALIGNMENT is set but
 > not if it isn't...

__dma_buffer_line() is just an internal implementation detail to take
care of string pasting properly.  Perhaps there should be a comment
warning people not to use it directly.

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/