Re: [PATCH - SH/Dreamcast] Add support for GD-Rom device

[Jens Axboe]

On Fri, Dec 21 2007, Adrian McMenamin wrote:
> 
> On Fri, 2007-12-21 at 13:14 +0100, Jens Axboe wrote:
> 
> > 
> > What is pages doing in gdrom_request()?
> > 
> 
> As the device doesn't do scatter-gather I've set
> blk_queue_max_segment_size to 1 and am not bothering with pages - is
> that wrong?

I mean this:

        unsigned long pages;
        pages = rq->backing_dev_info.ra_pages;

and you never use 'pages'.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/