Re: [PATCH] [RFC] be more verbose when probing EDD

[H. Peter Anvin]

Andi Kleen wrote:
> "H. Peter Anvin" <hpa@xxxxxxxxx> writes:
>
> > devzero@xxxxxx wrote:
> > >         /* Query EDD information */
> > >  #if defined(CONFIG_EDD) || defined(CONFIG_EDD_MODULE)
> > > -       query_edd();
> > > +        printf("Probing EDD (query Bios for boot-device information)\n");
> > > +        printf("If boot hangs here, you may have a buggy Bios. Try edd=skipmbr or edd=off");
> > > +        query_edd();
> > > +        printf("\rOK                                                                       \n");
> > >  #endif
> > This is awfully verbose.
>
> But useful. On the other hand we have lots of IMNSHO
> quite useless printks in early bootup that could be removed
> to make up for that
>
> (e.g. candidates would be the 
> "CPU: After/before generic identify"
> or 
> Entering add_active_range....) 
>
> printks and you can easily make up for the added verbosity.

Those don't live in an area of memory which is hard-limited to 32K.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/