Re: [PATCH] slub: /proc/slabinfo ABI compatibility

[Ingo Molnar]

* Pekka Enberg <penberg@xxxxxxxxxxxxxx> wrote:

> Hi Ingo,
> 
> On Dec 22, 2007 3:14 PM, Ingo Molnar <mingo@xxxxxxx> wrote:
> > Also please apply the cleanup patch below, it fixes 34 checkpatch errors
> > and warnings in mm/slub.c.
> 
> Those are already fixed in -mm:
> 
> http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc5/2.6.24-rc5-mm1/broken-out/slub-fix-coding-style-violations.patch
> http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc5/2.6.24-rc5-mm1/broken-out/slub-fix-coding-style-violations-checkpatch-fixes.patch

ah, didnt see that. Could you pick up bits of my patch because it seems 
to do a better job, such as proper c99 initializer:

+static struct notifier_block __cpuinitdata slab_notifier = {
+       .notifier_call = slab_cpuup_callback
+};

instead of your:

+static struct notifier_block __cpuinitdata slab_notifier = {
+       &slab_cpuup_callback, NULL, 0
+};

also, my patch fixes all the warnings as well, not just the errors. So 
please give it a second look ;-)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/