Re: [patch] Make MMCONFIG space (extended PCI config space) a driveropt-in issue

[Linus Torvalds]

On Sat, 22 Dec 2007, Jeff Garzik wrote:
> 
> But regardless of problems, enabling should be done globally, not per
> device...

I'm ok with trying the "globally" idea, but it has to be "globally but 
only if absolutely required".

And quite frankly, how do you tell whether it's absolutely required or 
not?

I have an idea: the drivers that really need it will do a "please enable 
MMCONFIG, because I will need it" thing?

Ok?

And then, since we *need* such a "pci_enable_mmconfig()" call anyway, why 
not let the driver give which device it controls too, so that we can print 
out the information (in case the machine then hangs immediately 
afterwards), and perhaps - if it is shown to help - only do the MMCONFIG 
cycles for that particular device?

Sounds like a plan?

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/