Re: drivers/net/iseries_veth.c dubious sysfs usage
From: Stephen Rothwell
Date: Sun Dec 23 2007 - 21:52:25 EST
Hi Greg,
On Wed, 12 Dec 2007 23:08:29 -0800 Greg KH <greg@xxxxxxxxx> wrote:
>
> Hm, ok, it's odd as you are the only driver in the whole tree doing
> something like this, but it seems semi-resonable, so I can't complain :)
>
> I'll fix the core up to allow you to do this, thanks for the
> explanation.
So if this "seems semi-reasonable", why was the result
gregkh-driver-driver-add-driver_add_kobj-for-looney-iseries_veth-driver
containing "Hopefully no one uses this function in the future and the
iseries_veth driver authors come to their senses so I can remove this
hack..." as part of its comment. If you expect respect, you need to
treat others the same way ...
If what the driver writers are doing is "looney" (in your opinion), then
please describe a better way of doing what they are trying to do.
Sometimes, if people have to abuse the infrastructure, it is possible that
the infrastructure is lacking?
--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
Attachment:
pgp00000.pgp
Description: PGP signature