Re: [PATCH] slub: /proc/slabinfo ABI compatibility

From: Christoph Lameter
Date: Wed Dec 26 2007 - 16:29:09 EST


On Mon, 24 Dec 2007, Pekka Enberg wrote:

> On Dec 24, 2007 9:12 PM, Christoph Lameter <clameter@xxxxxxx> wrote:
> > Hmmm... What is the combination of config variables that causes this? I
> > moved the count_partial function in mm in order to make the merge of slab
> > defrag easier.
>
> I think it's CONFIG_PROC_FS without CONFIG_SYSFS.

The only user of count_partial is in slab_objects() which is in a
section that is

#if defined(CONFIG_SYSFS) && defined(CONFIG_SLUB_DEBUG)

There should be no use if CONFIG_SYSFS is not set. I think we get a
warning about a function that is never called when compiling the current
mm code without SLUB_DEBUG or CONFIG_SYSFS (because the slab defrag use
has not been merged yet).

In mm count_partial() is always defined. In Linus tree count_partial()
comes just before slab_objects().

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/