Re: [PATCH 25/26] atl1: add NAPI support

[Joonwoo Park]

2008/1/1, jacliburn@xxxxxxxxxxxxx <jacliburn@xxxxxxxxxxxxx>:
> From: Jay Cliburn <jacliburn@xxxxxxxxxxxxx>
>
> Add support for NAPI, styled after the e1000 NAPI implementation.  That we
> follow the e1000 for NAPI shouldn't come as much of a surprise, since the
> entire atl1 driver is based heavily upon it.
>
> Signed-off-by: Jay Cliburn <jacliburn@xxxxxxxxxxxxx>
> ---
>  drivers/net/Kconfig     |   14 ++++
>  drivers/net/atlx/atl1.c |  151 +++++++++++++++++++++++++++++++++++++++++++++--
>  drivers/net/atlx/atl1.h |   20 ++++++
>  drivers/net/atlx/atlx.h |    7 ++-
>  4 files changed, 186 insertions(+), 6 deletions(-)
>
> +       if ((!tx_cleaned && (work_done == 0)) ||
> +               !netif_running(poll_dev)) {
> +quit_polling:
> +               netif_rx_complete(poll_dev, napi);
> +
> +               if (!test_bit(__ATL1_DOWN, &adapter->flags))
> +                       atlx_irq_enable(adapter);
> +       }

Hi Jay,
if buget == work_done is true, you should not call netif_rx_complete.
Searching recent netdev mailbox would be help.

Thanks.
Joonwoo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/