Re: [PATCH linux-acpi] Correct wakeup set error and append a new column PCI ID

[Pavel Machek]

On Wed 2008-01-02 10:03:59, Yi Yang wrote:
> On Wed, 2008-01-02 at 00:20 +0100, Pavel Machek wrote:
> > Hi!
> > 
> > > /proc/acpi/wakeup is also case-sensitive, case-insensitive is better.
> > 
> > Why?
> A user uses device bus id like 'C093' to enable or disable wakeup of the
> device, for example
> 
> echo "C093" > /proc/acpi/wakeup
> 
> but i think "c093" should also be ok. i.e.

Why do you think so? Unix is generally case-sensitive. I see ascii
text in .../wakeup. Maybe some bios vendor is crazy enough to have
wakeup devices called 'wake', 'Wake', 'wAke', 'waKe', 'wakE'?

> > Maybe this file should be left for compatibility and we should present
> > something reasonable in /sys? Can't you already get PCI ID from sysfs
> > node?
> PCI ID can be gotten from sysfs, but it is a unique identifier for a
> device, a user can get device name from /usr/share/hwdata/pci.ids in any
> dstribution by PCI ID, he/she is unnecessary to use bus number to get
> device name, bus number is platform-specific, but PCI ID is
> platform-independent.

If the same info can be gotten from 'sysfs node' field, new field
should not be added.


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/