Re: [x86] kernel/audit.c cleanup according to checkpatch.pl

[Ingo Molnar]

* Jörn Engel <joern@xxxxxxxxx> wrote:

> > -		       "audit: audit_lost=%d audit_rate_limit=%d audit_backlog_limit=%d\n",
> > +		       "audit: audit_lost=%d audit_rate_limit=%d "
> > +		       "audit_backlog_limit=%d\n",
> >  		       atomic_read(&audit_lost),
> >  		       audit_rate_limit,
> >  		       audit_backlog_limit);
> 
> This hunk is a bit questionable.  It can easily deceive a reader to 
> assume two seperate lines printed out and sometimes defeats grepping 
> for printk output to find the code generating the message.

not to make a big issue out of this, but when was the last time you 
tried to grep this way:

  grep -E "audit_rate_limit=[0-9]+ audit_backlog" */*.c

?

That's pretty much the only grep pattern that would break. People 
usually grep on the constant portion of the string, so breaking up a 
line along a variable boundary is perfectly okay.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/