Re: [PATCH] isdn/i4l: Fix DLE handling for i4l-audio

[David Miller]

From: Matthias Goebl <matthias@xxxxxxxxx>
Date: Thu, 3 Jan 2008 23:00:03 +0100

> --- linux-2.6.23.12.orig/drivers/isdn/i4l/isdn_tty.c	2007-12-22 21:13:49.000000000 +0100
> +++ linux-2.6.23.12/drivers/isdn/i4l/isdn_tty.c	2007-12-26 11:37:18.000000000 +0100
> @@ -85,6 +85,8 @@
>  								tty_insert_flip_char(tty, DLE, 0);
>  							tty_insert_flip_char(tty, *dp++, 0);
>  						}
> +						if (*dp == DLE)
> +							tty_insert_flip_char(tty, DLE, 0);
>  						last = *dp;
>  					} else {
>  #endif

I'm not sure this part is correct.

Here, *dp will be assigned to 'last'.

The rest of the code (after the else block) then reads:

					if (info->emu.mdmreg[REG_CPPP] & BIT_CPPP)
						tty_insert_flip_char(tty, last, 0xFF);
					else
						tty_insert_flip_char(tty, last, TTY_NORMAL);

which should push that character out to the TTY.

With your change we will push a DLE out twice in such a case,
and that doesn't seem right.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/