Re: [PATCH] This patch to profile.c fixes a few errors reported bycheckpatch.pl

[Ingo Molnar]

* Paolo Ciarrocchi <paolo.ciarrocchi@xxxxxxxxx> wrote:

> > i.e. take the implicit assignment out of the condition. (it's easy 
> > to mistake it for '==' while reviewing the code and forgetting about 
> > the assignment's side-effect)
> 
> OK, thanks.
> 
> Is the following correct?
> 
> Before:
>  if (!(entry = create_proc_entry("prof_cpu_mask", 0600, root_irq_dir)))
> 
> After:
> entry = create_proc_entry("prof_cpu_mask", 0600, root_irq_dir)
> if (!entry)
> 
> BTW, how can i compile only the profile.c file?

make kernel/profile.o

> I would like to verify that my changes (now I'm at total: 2 errors, 1 
> warnings, 599 lines checked) doesn't impact on the compiled code?

check out:

 http://people.redhat.com/mingo/misc/q-size-obj-compare

which does a size and md5 comparison. (assuming your patch is in a quilt 
queue) But if you reorder symbols (due to the EXPORT_SYMBOL moving) the 
md5 might differ. (but size should still be the same)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/