Re: [PATCH] profile: further Codying Style fixes

From: Ingo Molnar
Date: Sun Jan 06 2008 - 05:26:17 EST



* Paolo Ciarrocchi <paolo.ciarrocchi@xxxxxxxxx> wrote:

> Further codying style fixes on top of:
> http://marc.info/?l=linux-kernel&m=119940325306693&w=2

thanks, applied.

> 1 Warning is still not killed:
> WARNING: externs should be avoided in .c files
> #509: FILE: profile.c:509:
> + extern int setup_profiling_timer(unsigned int multiplier);
>
> I don't know how to fix it :-/

simply move that line to include/linux/profile.h. (no need to preserve
the CONFIG_SMP - on !SMP the function prototype line will not be used)

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/