Re: [PATCH] block2mtd lockdep_init_map warning

From: Peter Zijlstra
Date: Mon Jan 07 2008 - 05:34:57 EST



On Mon, 2008-01-07 at 11:20 +0100, JÃrn Engel wrote:
> On Mon, 7 January 2008 11:05:26 +0100, Peter Zijlstra wrote:
> >
> > Would something like this work for people?
>
> Looks a lot better than what I thought of. However, does the #ifdef
> within is_module_address() make sense when afaict lockdep is the only
> caller of that function? Looks as if the whole function should be made
> conditional or none of it.

Ah, I hadn't bothered to check if there were more users. /me does a (not
so quick) git grep and finds lockdep is indeed the only caller. Sure, we
can move the whole function into the ifdef.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/