Re: [patch 2/2] Use the stack frames to get exact stack-traces forCONFIG_FRAMEPOINTER on x86-64

[Ingo Molnar]

* Arjan van de Ven <arjan@xxxxxxxxxxxxx> wrote:

> x86 32 bit already has this feature: This patch uses the stack frames 
> with frame pointer into an exact stack trace, by following the frame 
> pointer. This only affects kernels built with the CONFIG_FRAME_POINTER 
> config option enabled, and greatly reduces the amount of noise in 
> oopses.

nice! Applied.

> The code tries to use the frame pointers to do a backtrace, but if it 
> smells iffy or invalid, falls back to the traditional way of printing 
> backtraces, to make sure that at least some useful backtrace is 
> created.
>
> Due to the fragility and importance of the backtrace code, this needs 
> to be well reviewed and well tested before merging into mainlne.

yeah, agreed. But i think this is still fundamentally more robust than 
the unwind info based backtracer. Cool stuff!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/