Re: [PATCH 4/4] Fixup container_of() usage

From: Rusty Russell
Date: Tue Jan 08 2008 - 05:41:23 EST


On Tuesday 08 January 2008 19:46:29 Alexey Dobriyan wrote:
> Using "attr" twice is not OK, because it effectively prohibits such
> container_of() on variables not named "attr".
>
> Signed-off-by: Alexey Dobriyan <adobriyan@xxxxx>

Thanks, nice catch. Took me a while to understand that you meant "you can't
use to_sq_sysfs_attr() on a variable not named attr".

Acked-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/