Re: [patch 2/2] track and print last unloaded module in the oops trace

[DM]

On Jan 7, 2008 12:19 AM, Arjan van de Ven <arjan@xxxxxxxxxxxxx> wrote:
[...]
> This patch tracks the last unloaded module, and prints this as part of the
> module list in the oops trace.
>
[...]
>        }
> +       /* Store the name of the last unloaded module for diagnostic purposes */
> +       sprintf(last_unloaded_module, mod->name);
>        free_module(mod);
>

Why use sprintf? If a module name contains the % character we could
overflow the buffer. Or is module-unloading root-only and we don't
care?

Best regards,
dm.n9107
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/