Re: [patch 2/2] track and print last unloaded module in the oopstrace

[Ingo Molnar]

* DM <dm.n9107@xxxxxxxxx> wrote:

> On Jan 8, 2008 3:26 PM, Arjan van de Ven <arjan@xxxxxxxxxxxxx> wrote:
> > >
> > > Why use sprintf? If a module name contains the % character we could
> > > overflow the buffer. Or is module-unloading root-only and we don't
> > > care?
> >
> > module loading isn't just root only; the name comes from an already loaded module.
> > If you can load kernel modules of your choice you own the entire kernel already anway
> >
> 
> Still, strcpy seems like a better choice IMHO.

agreed, this just isnt obvious IMO:

+       sprintf(last_unloaded_module, mod->name);

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/