Re: [PATCH] ip[6]_tables.c: remove some inlines

[Patrick McHardy]

Denys Vlasenko wrote:
> On Monday 31 December 2007 17:00, Patrick McHardy wrote:
> > Denys Vlasenko wrote:
> > > ip[6]_tables.c seem to abuse inline.
> > >
> > > This patch removes inlines except those which are used
> > > by packet matching code and thus are performance-critical.
> > >   
> > Some people also consider the ruleset replacement path performance
> > critical, but overall I agree with your patch. I'm travelling currently
> > though so it will take a few days until I'll apply it.
> >
> > Do you have some numbers that show the actual difference these
> > changes make?
>
> Before:
>
> $ size */*/*/ip*tables*.o
>    text    data     bss     dec     hex filename
>    6402     500      16    6918    1b06 net/ipv4/netfilter/ip_tables.o
>    7130     500      16    7646    1dde net/ipv6/netfilter/ip6_tables.o
>
> After:
>
> $ size */*/*/ip*tables*.o
>    text    data     bss     dec     hex filename
>    6307     500      16    6823    1aa7 net/ipv4/netfilter/ip_tables.o
>    7010     500      16    7526    1d66 net/ipv6/netfilter/ip6_tables.o


Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/