Re: [PATCH] x86_64: enable irq in default_idle

[Hiroshi Shimamoto]

Ingo Molnar wrote:
> * Hiroshi Shimamoto <h-shimamoto@xxxxxxxxxxxxx> wrote:
> 
>> Hi Ingo,
>>
>> I think local_irq_enable() is missing in default_idle() on x86_64. 
>> It's for recent x86 tree.
>>
>> From: Hiroshi Shimamoto <h-shimamoto@xxxxxxxxxxxxx>
>> Subject: [PATCH] x86_64: enable irq in default_idle
>>
>> local_irq_enable() is missing after sched_clock_idle_wakeup_event().
> 
> thanks Hiroshi, applied.
> 
> The effects of this bug should be increased latencies on 64-bit. Did you 
> notice these latencies, or did you find the bug in some other way (code 
> review)?

I found this when I was comparing 32-bit and 64-bit source code
for x86 unification.

Thanks,
Hiroshi Shimamoto

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/