Re: [PATCH 00 of 10] x86: unify asm/pgtable.h

[Ingo Molnar]

* Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:

> Ingo Molnar wrote:
>> * Ingo Molnar <mingo@xxxxxxx> wrote:
>>
>>   
>>>  #define __PAGE_KERNEL_EXEC						\
>>> -	(_PAGE_PRESENT | _PAGE_RW | _PAGE_DIRTY | _PAGE_ACCESSED | _PAGE_GLOBAL)
>>> +	(_PAGE_PRESENT | _PAGE_RW | _PAGE_DIRTY | _PAGE_ACCESSED)
>>>     
>
> This shouldn't be necessary.  The old 64-bit code defined everything 
> without _PAGE_GLOBAL, but then used a MAKE_GLOBAL() macro to OR it in 
> later.  This seemed a bit roundabout to me, so I just put it in from 
> the outset.

yeah, just noticed it - and the cleanup you did certainly improves it.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/