Re: [PATCH] Kprobes: Add kprobes smoke tests that run on boot

[Sam Ravnborg]

On Wed, Jan 09, 2008 at 08:00:03AM +0000, Christoph Hellwig wrote:
> On Tue, Jan 08, 2008 at 11:18:02PM +0100, Ingo Molnar wrote:
> > 
> > * Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
> > 
> > > Ananth N Mavinakayanahalli <ananth@xxxxxxxxxx> writes:
> > > >  kernel/kprobes.c        |    2 
> > > >  kernel/test_kprobes.c   |  216 ++++++++++++++++++++++++++++++++++++++++++++++++
> > > 
> > > Can you put this somewhere else please? I know there are already some 
> > > test files in kernel/* but imho they all belong into some other 
> > > directory.
> > 
> > agreed - lib/* would be the right place i think - we've got 
> > lib/locking-selftest.c already.
> 
> Actually the right place would be to have a separate toplevel directory
> I think, and a separate menu in the kernel config machinery.  Thay way
> tests are in one place and easily spottable.

Seconded...

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/