Re: [patch 1/1] Convert drivers in drivers/char/drm to use .unlocked_ioctl

[Kevin Winchester]

On Jan 8, 2008 11:37 PM, Dave Airlie <airlied@xxxxxxxx> wrote:
>
> > The drm drivers in this patch all used drm_ioctl to perform their
> > ioctl calls.  The common function is converted to use lock_kernel()
> > and unlock_kernel() and the drivers are converted to use .unlocked_ioctl
> >
>
> NAK
>
> I've started looking at this already in the drm git tree, I'm going to
> provide both locked and unlocked paths for drivers to choose, as we need
> to audit the drivers on a per-driver basis, the other option is to provide
> wrappers in each driver to do the lock/unlock kernel and leave drm_ioctl
> alone..
>
> I'll take a look kmalloc failure case sounds like a bug though..
>

No problem.  I interpreted Andi's request for patches as a way to ensure
that people were actively working to remove the BKL from ioctl calls.
Since you appear to already have been working towards that end, the patch
is not really necessary.

-- 
Kevin Winchester
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/