Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl

From: Richard Knutsson
Date: Wed Jan 09 2008 - 08:17:55 EST


Andre Noll wrote:
On 17:40, Andi Kleen wrote:
Here's a proposal for some useful code transformations the kernel janitors
could do as opposed to running checkpatch.pl.

Here's my take on drivers/scsi/sg.c. It's only compile-tested on x86-64.
... and x86 with all(yes|mod)config. :)

Would had preferred:

if (x) {
result = -Exxxx;
goto out;
}

then:

result = -Exxxx;
if (x)
goto out;

but it looks correct.

cu,
Richard

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/