Re: [RFC PATCH 10/11] mcount tracer show task comm and pid

[Ingo Molnar]

* Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxx> wrote:

> static inline int vmalloc_fault(unsigned long address)
> {
>         unsigned long pgd_paddr;
>         pmd_t *pmd_k;
>         pte_t *pte_k;
>         /*
>          * Synchronize this task's top level page-table
>          * with the 'reference' page table.
>          *
> ---->    * Do _not_ use "current" here. We might be inside
>          * an interrupt in the middle of a task switch..
>          */
>         pgd_paddr = read_cr3();
>         pmd_k = vmalloc_sync_one(__va(pgd_paddr), address);
>         if (!pmd_k)
>                 return -1;
>         pte_k = pte_offset_kernel(pmd_k, address);
>         if (!pte_present(*pte_k))
>                 return -1;
>         return 0;
> }
> 
> At context switch on x86, loading the registers is done first, and 
> only after the is the current pointer set. However, for vmalloc 
> faults, it's the value in the cr3 register that is important, which 
> may not correspond to the cr3 value saved in "current".
> 
> So, I think using the "pid" and "comm" fields of current, even in NMI 
> context, is not a problem, just as you said. For early boot, the 
> current task will be init_task, which has pid = 0 and comm = 
> "swapper", still ok.

yeah - during the context-switch the value of 'current' might be 'stale' 
in a number of ways, but it's always atomically and coherently either 
pointing to the previous task or the next task. So from a tracing POV 
it's perfectly safe to use it (and we've been doing that for ages with 
the mcount stuff).

(The notrace mcount exclusions arent really to avoid any tracing 
badness, they are mostly to make the trace less spammy and more 
readable.)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/