Re: [PATCH 1/1] : hwmon - new chip driver for TI ADS7828 A-D

[Andrew Morton]

On Fri, 4 Jan 2008 07:34:39 +0000
Steve Hardy <steve@xxxxxxxxxxxxxxxxxxx> wrote:

> Andrew/Jean,
> 
> Sorry for the delay - christmas & getting mutt working delayed my
> revised patch.  Here is an updated patch against 2.6.24-rc6, which
> hopefully addresses all comments made so far.
> 
> Jean - you mentioned declaring the devices as platform data & writing
> a new-style I2C driver - are there any examples of this approach I can
> refer to?  I simply copied what is/was currently in-tree for this
> driver, which seems to work well with the hardware I'm working with (a
> COTS CPCI carrier)
> 
> Since I've dropped Thunderbird I hope the patch mangling will be
> fixed.
> 
> Any problem, please let me know.
>

The above doesn't constitute a usable changelog.  I guess we don't really
need anything in this patch but please do remember that the changelog text
should be included in each new rev of a patch.

> 
> Signed-Off by Steve Hardy <steve@xxxxxxxxxxxxxxxxxxx>

"Signed-off-by:", please.

 Documentation/hwmon/ads7828 |   38 ++++
 drivers/hwmon/Kconfig       |   10 +
 drivers/hwmon/Makefile      |    1 
 drivers/hwmon/ads7828.c     |  296 ++++++++++++++++++++++++++++++++++
 4 files changed, 345 insertions(+)

I assumed that this is to be merged via Mark's git-hwmon tree.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/