Re: [PATCH] x86: trivial whitespace in kprobes.c

[Masami Hiramatsu]

Masami Hiramatsu wrote:
> Harvey Harrison wrote:
>> Signed-off-by: Harvey Harrison <harvey.harrison@xxxxxxxxx>
> 
> Acked-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
> 
>> ---
>> Ingo, you could/should probably fold this into Masami's kprobe
>> unification patch.
> 
> The original code had these whitespace, because (I think)
> kretprobe_trampoline_holder() had just hold a memory space
> for hooking function return. And now, it has actual code.

Hmm, this function still a bit special, because it is not
called directly. kretprobe uses kretprobe_trampoline symbol,
which is defined in this function.
Anyway, I think the whitespace does not help us understand it...

> So the whitespace can be removed.

Thank you,

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: mhiramat@xxxxxxxxxx, masami.hiramatsu.pt@xxxxxxxxxxx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/