Re: [PATCH 0 of 2] x86: a couple of misc patches

[Jan Beulich]

>2. I noticed the _PAGE_PCD|_PAGE_PWT combination being used a lot, so
>I created _PAGE_NOCACHE to wrap them up.  asm-x86/fb.h uses plain
>_PAGE_PCD; should it be _PAGE_NOCACHE too?

Setting PCD but not PWT (or the other way around) is yielding not fully
defined behavior (model specific) as per the doc, so it doen't seem to be
too good an idea to use this. However, adding PWT here may not be what
is desirable either (as it'll make the referenced memory UC unconditionally,
whereas WC is generally more desirable here). It would seem to me,
though, that PWT alone would be the better choice in this situation
(despite this also yielding model specific behavior).

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/