Re: 2.6.24-rc6-mm1 (driver core/sysfs)

[Greg KH]

On Mon, Dec 31, 2007 at 12:11:15PM -0800, Randy Dunlap wrote:
> On Sat, 22 Dec 2007 23:30:56 -0800 Andrew Morton wrote:
> 
> > 
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc6/2.6.24-rc6-mm1/
> 
> 
> With CONFIG_BLOCK=n:
> 
>   LD      drivers/block/built-in.o
> /local/linsrc/linux-2.6.24-rc6-mm1/drivers/base/core.c: In function 'device_add_class_symlinks':
> /local/linsrc/linux-2.6.24-rc6-mm1/drivers/base/core.c:707: error: 'part_type' undeclared (first use in this function)
> /local/linsrc/linux-2.6.24-rc6-mm1/drivers/base/core.c: In function 'device_remove_class_symlinks':
> /local/linsrc/linux-2.6.24-rc6-mm1/drivers/base/core.c:746: error: 'part_type' undeclared (first use in this function)
> make[3]: *** [drivers/base/core.o] Error 1
> 
> 
> and that is after fixing (in some sense) the first CONFIG_BLOCK=n
> problem with the patch below.  Please test lots of configs.
> and/or use 'make randconfig' (automated, scripted, e.g., etc.).
> maybe check Documentation/SubmitChecklist.  :)

Ingo seems to be saying that he has some kind of "automated" build
system to do this kind of checking.  Ingo, did you ever post how you did
this anywhere?  I have enough spare machines here that I should be able
to set up something to test my stuff this way easier than doing it by
hand all the time (as the above problem proves I do miss things :(  )

> ---
> 
> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> 
> Parts of driver core use blk_lookup_devt() when CONFIG_BLOCK=n,
> so provide an short inline version of it for that case.
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>

Thanks for this patch, I've merged it with the original block patch so
there is no regression along the way.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/