[PATCH 4/7] rtc : use class iteration api

From: Dave Young
Date: Sat Jan 12 2008 - 04:50:26 EST


Convert to use the class iteration api.

Signed-off-by: Dave Young <hidave.darkstar@xxxxxxxxx>

---
drivers/rtc/interface.c | 22 ++++++++++++----------
1 file changed, 12 insertions(+), 10 deletions(-)

diff -upr linux/drivers/rtc/interface.c linux.new/drivers/rtc/interface.c
--- linux/drivers/rtc/interface.c 2008-01-11 18:06:38.000000000 +0800
+++ linux.new/drivers/rtc/interface.c 2008-01-11 18:06:38.000000000 +0800
@@ -251,20 +251,23 @@ void rtc_update_irq(struct rtc_device *r
}
EXPORT_SYMBOL_GPL(rtc_update_irq);

+static int __rtc_match(struct device *dev, void *data)
+{
+ char *name = (char *)data;
+
+ if (strncmp(dev->bus_id, name, BUS_ID_SIZE) == 0)
+ return 1;
+ return 0;
+}
+
struct rtc_device *rtc_class_open(char *name)
{
struct device *dev;
struct rtc_device *rtc = NULL;

- down(&rtc_class->sem);
- list_for_each_entry(dev, &rtc_class->devices, node) {
- if (strncmp(dev->bus_id, name, BUS_ID_SIZE) == 0) {
- dev = get_device(dev);
- if (dev)
- rtc = to_rtc_device(dev);
- break;
- }
- }
+ dev = class_find_device(rtc_class, name, __rtc_match);
+ if (dev)
+ rtc = to_rtc_device(dev);

if (rtc) {
if (!try_module_get(rtc->owner)) {
@@ -272,7 +275,6 @@ struct rtc_device *rtc_class_open(char *
rtc = NULL;
}
}
- up(&rtc_class->sem);

return rtc;
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/