Re: [RFC, PATCH] watchdog on gpio

[Marc Pignat]

On Friday 11 January 2008, Florian Fainelli wrote:
> Hello Marc,
> 
> Your patch looks good to me, and I have been waiting for something like 
> this :). Other comments below.
> 
> Le jeudi 10 janvier 2008, Marc Pignat a écrit :
> > +#include <asm/uaccess.h>
> > +#include <asm/arch/gpio.h>
> 
> At first sight, this will only work with the platforms which have implemented 
> gpiolib, some (like MIPS) still use the old generic GPIO API. So I think the 
> include will not work here for anything than ARM, correct me if I am wrong.
find arch -name "Kconfig" -exec grep -q "GENERIC_GPIO" {} \; -print
arch/arm/Kconfig
arch/mips/Kconfig
arch/avr32/Kconfig
arch/blackfin/Kconfig

It seems that no only arm are using GENERIC_GPIO, even some mips chips.
I probably missed wirting the subject right, should be "watchdog on GENERIC_GPIO" :)

...
> 
> Did you look into hooking into Wim's uniform watchdog driver :
> 
> http://git.kernel.org/?p=linux/kernel/git/wim/linux-2.6-watchdog-experimental.git;a=commit;h=732c54027e6c866f98857c4a6d1c6c466459dcd5
Now yes, interesting!

Regards

Marc

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/