Re: [PATCH] driver: ip27-rtc - convert ioctl to unlocked_ioctl

From: Jiri Slaby
Date: Mon Jan 14 2008 - 10:14:38 EST


On 01/14/2008 07:38 AM, Cyrill Gorcunov wrote:
This patch converts ioctl call to unlocked_ioctl form. It's possible
due to rtl_lock spinlock protection.

Signed-off-by: Cyrill Gorcunov <gorcunov@xxxxxxxxx>
---
The patch is *not* tested but the patch does not bring _much_ changes
so it wouldn't break the compilation procedure.

If there is problem with attachment - i could send it as inline
form today evening.

Yes, please, especially if it is app/octet-stream (base64 encoded plaintext). Also Cc akpm or somebody who will pick your patch up.

Andi, Jiri, Alexey the only thing I do complain about -
is time set/read from several user threads that uses same
(duplicated) file descriptor. Could there be useless thread
spins instead of sleep (in case if this unlocked_ioctl were
protected by mutex)?

Sorry, what?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/